feat(testing-cli): implement benchmark coverage script#1898
Open
LouisTsai-Csie wants to merge 11 commits intoethereum:forks/amsterdamfrom
Open
feat(testing-cli): implement benchmark coverage script#1898LouisTsai-Csie wants to merge 11 commits intoethereum:forks/amsterdamfrom
LouisTsai-Csie wants to merge 11 commits intoethereum:forks/amsterdamfrom
Conversation
…um#1842) Co-authored-by: spencer <spencer.tb@ethereum.org>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1898 +/- ##
============================================
Coverage 83.87% 83.87%
============================================
Files 402 402
Lines 25101 25101
Branches 2285 2285
============================================
Hits 21053 21053
Misses 3609 3609
Partials 439 439
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Introduces a new
CLItoolbenchmark_coveragethat generates a markdown/JSON/terminal report showing which opcodes have benchmark test coverage for different benchmark modes (--gas-benchmark-values&--fixed-opcode-countmode).--gas-benchmark-values): Tests usingbenchmark_testwrapper--fixed-opcode-count): Tests usingbenchmark_test+target_opcode=+code_generator=ethereum.forks.osaka.vm.instructions.Opsfor accurate sorting and completenessSHA3->KECCAK256,DIFFICULTY->PREVRANDAO).Detection logic:
target_opcode=+code_generator=target_opcode=withoutcode_generator=target_opcode=, has@pytest.mark.parametrize("opcode", [...])Usage:
Current Coverage Report
🔗 Related Issues or PRs
Require #1869
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture